Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kad): impl Display on QueryId #4814

Merged

Conversation

stormshield-frb
Copy link
Contributor

@stormshield-frb stormshield-frb commented Nov 7, 2023

Description

Fixes: #4813.

Notes & open questions

N/A

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this makes sense. I kicked CI!

protocols/kad/CHANGELOG.md Show resolved Hide resolved
@stormshield-frb stormshield-frb force-pushed the feat/add-display-impl-on-queryid branch 4 times, most recently from 2240275 to 9c51b44 Compare November 9, 2023 09:04
@mergify mergify bot merged commit 2fb671c into libp2p:master Nov 10, 2023
71 checks passed
@stormshield-frb stormshield-frb deleted the feat/add-display-impl-on-queryid branch November 27, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kad: impl Display on QueryId
3 participants