Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redundant async signature #5468

Merged
merged 6 commits into from
Jun 18, 2024
Merged

refactor: remove redundant async signature #5468

merged 6 commits into from
Jun 18, 2024

Conversation

dariusc93
Copy link
Member

Description

Resolves #4832

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dariusc93 dariusc93 changed the title refactor: Remove redundant async signature refactor: remove redundant async signature Jun 13, 2024
@dariusc93 dariusc93 marked this pull request as ready for review June 17, 2024 23:07
guillaumemichel
guillaumemichel reviewed Jun 18, 2024
View reviewed changes
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
libp2p/src/builder/phase/quic.rs Show resolved Hide resolved
dariusc93 and others added 2 commits June 18, 2024 07:43
@dariusc93 @guillaumemichel
Update libp2p/CHANGELOG.md
9840b83 
Co-authored-by: Guillaume Michel <guillaumemichel@users.noreply.github.com>
@dariusc93
chore: remove async sig
e29073b
@dariusc93
Copy link
Member Author

Though not related to this PR, seems like write_after_peer_dropped_stream failed though nothing changed that should have caused it to failed nor does it fail locally. Maybe just a flaky test?

@guillaumemichel
Copy link
Contributor

Though not related to this PR, seems like write_after_peer_dropped_stream failed though nothing changed that should have caused it to failed nor does it fail locally. Maybe just a flaky test?

I have rerun the test, and it passed. So the test is probably flaky.

jxs
jxs approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Darius!

libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
@jxs jxs added the send-it label Jun 18, 2024
@mergify mergify bot merged commit 0b1733d into libp2p:master Jun 18, 2024
72 checks passed
TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this pull request Sep 14, 2024
@dariusc93 @TimTinkers
refactor: remove redundant async signature
061f1c5 
Resolves libp2p#4832

Pull-Request: libp2p#5468.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@guillaumemichel guillaumemichel guillaumemichel approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove async from DNS builder methods
3 participants
@dariusc93 @guillaumemichel @jxs