feat(hole-punch): update rust v0.52 to master
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
changed the title
masterv0.52 to master
|
cc @diegomrsantos Once this is merged, you should be good to go to run the entire test suite on ARM64 without any other patches. |
thomaseizinger
commented
Oct 27, 2023
|
Merging here because it includes a bugfix that caused flakiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
v0.52version string was really just a placeholder. Initially, I thought that we might merge libp2p/rust-libp2p#4549 before the release cut-off forv0.53but that didn't happen.To communicate this more clearly, we rename the current image to
rust-master. We are also updating it to actually point to a commit on master. Previously, it was pointing to a commit in libp2p/rust-libp2p#4549. This new commit includes an important bug-fix (libp2p/rust-libp2p#4747) that caused the QUIC hole-punch test to occasionally fail.Once we cut the v0.53 release, this version should be promoted to that.
As a side-benefit, the new commit points to a version that includes the updated Dockerfile and allows the tests to be run on ARM64.