Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker cross compile - remove MIPS target platform #1299

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

starypatyk
Copy link
Contributor

Follow up to #1297 and #1298

Given that:

  • MSRV was moved up to 1.73.
  • Even with rust 1.71 the MIPS target did not build successfully.
  • Apparently there is hardly any interest in maintaining the MIPS platform.
  • Last but not least - the Docker image for cross-compilation did not build - since MIPS target was demoted to tier 3 at 1.72.

I propose to remove the MIPS architecture entirely from the Docker image for cross compilation.

After these changes, I was able to:

  • Build the Docker image.
  • Cross compile for all remaining platforms.
  • Verify that x86_64 and aarch64 binaries work fine on Ubuntu 22.04 (regular PC) and Raspberry PI OS (64-bit/bookworm/Raspberry Pi 3) respectively.

Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
@roderickvd
Copy link
Member

All good to me. If someone pops up in need of MIPS support, he/she is more than welcome to contribute and maintain that him/herself.

@roderickvd roderickvd merged commit 369b953 into librespot-org:dev Jun 11, 2024
@starypatyk starypatyk deleted the docker-remove-mips branch June 11, 2024 20:58
@starypatyk
Copy link
Contributor Author

I have updated the Cross compiling Wiki page to reflect current status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants