Fix Alsa softvol linear mapping #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelherger
added a commit
to michaelherger/librespot
that referenced
this pull request
Feb 17, 2022
* spotty-dev: (76 commits) Quantum-realm level normalisation optimization (librespot-org#965) Only log runtime argument if it starts with a dash "-" Improved error handling when fetching tokens or track data. update changelog Prevent shuffle crash Remove basic normalisation deprecation warning Fix Alsa softvol linear mapping (librespot-org#950) simplify get_factor (librespot-org#942) Update LMS integration to Remove unsafe code (librespot-org#940) Save some more CPU cycles in the limiter (librespot-org#939) New dynamic limiter for very wide dynamic ranges (librespot-org#935) Fix `--device` argument to various backends (librespot-org#938) examples/playlist_tracks: Use normal URI parser Fix clippy lint warning Clean up list_compatible_devices Sink: pass ownership of the packet on write() Restore giving feedback about auth success. The plugin is checking for this. Remove that last couple unwraps from main Fix auto fallback for --alsa-mixer-device and --alsa-mixer-index ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--volume-rangewas set, that propagated to the mapped volume control, but not to the Alsa mixer itself. This caused incorrectmapped_to_linearcalculations.Fixes: #948