Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

Feat: Let peer dependencies work with sb@next #27

Closed
wants to merge 2 commits into from
Closed

Feat: Let peer dependencies work with sb@next #27

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd3800
Feat: Let peer dependencies work with sb@next
benbender Jul 16, 2021
fcc46e1
Update package.json
lifeiscontent Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
"main": "preset.js",
"name": "storybook-addon-next-router",
"peerDependencies": {
"@storybook/addon-actions": "^6.0.0",
"@storybook/addons": "^6.0.0",
"@storybook/client-api": "^6.0.0",
"@storybook/addon-actions": "^6 || >=6.0.0-0 || >=6.1.0-0 || >=6.2.0-0 || >=6.3.0-0 || >=6.4.0-0",
"@storybook/addons": "^6 || >=6.0.0-0 || >=6.1.0-0 || >=6.2.0-0 || >=6.3.0-0 || >=6.4.0-0",
"@storybook/client-api": "^6 || >=6.0.0-0 || >=6.1.0-0 || >=6.2.0-0 || >=6.3.0-0 || >=6.4.0-0",
Copy link
Owner

@lifeiscontent lifeiscontent Jul 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@storybook/addon-actions": "^6 || >=6.0.0-0 || >=6.1.0-0 || >=6.2.0-0 || >=6.3.0-0 || >=6.4.0-0",
"@storybook/addons": "^6 || >=6.0.0-0 || >=6.1.0-0 || >=6.2.0-0 || >=6.3.0-0 || >=6.4.0-0",
"@storybook/client-api": "^6 || >=6.0.0-0 || >=6.1.0-0 || >=6.2.0-0 || >=6.3.0-0 || >=6.4.0-0",
"@storybook/addon-actions": "^6.0.0",
"@storybook/addons": "^6.0.0",
"@storybook/client-api": "^6.0.0",

@benbender does this suggestion work for you as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lifeiscontent That's the failing config :) Context is automatic installation and strict enforcing of peer-deps in npm 7. See https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies

Copy link
Owner

@lifeiscontent lifeiscontent Jul 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbender how are you able to even get storybook running? Last time I checked the peer deps were really messed up in storybook. do you mind putting a small project together so I can test this change?

"next": "^9.0.0 || ^10.0.0 || ^11.0.0",
"react": "^16.8.0 || ^17.0.0",
"react-dom": "^16.8.0 || ^17.0.0"
Expand Down