Fix for rust commit 3dcd2157403163789aaf21a9ab3c4d30a7c6494d 'Switch to ... #60
Conversation
…to purely namespaced enums'
| @@ -51,6 +51,9 @@ | |||
| * then it can just discard the first sequence and can emit the fixed string on an error. | |||
| * It still has to feed the input bytes starting at the second offset again. | |||
| */ | |||
| pub use DecoderTrap::{DecodeStrict,DecodeReplace,DecodeIgnore,DecoderCall}; | |||
| pub use EncoderTrap::{EncodeStrict,EncodeReplace,EncodeIgnore,EncodeNcrEscape,EncoderCall}; | |||
There was a problem hiding this comment.
Could we take the opportunity to rename the variants, instead?
There was a problem hiding this comment.
Sure. What should they be renamed as?
There was a problem hiding this comment.
Remove the Decode and Encode prefixes on the variant names, but don’t re-export them. Take advantage on the new language feature! @lifthrasiir, what do you think? By the way, the language change is rust-lang/rust#18973
There was a problem hiding this comment.
So you are suggesting to remove the re-export, and use the fully qualified name elsewhere. So, DecoderTrap::Strict for example after the rename. Just making sure I'm thinking the same as you.
There was a problem hiding this comment.
I have no problem with renaming them. See the below for other comments.
|
Ideally a proper deprecation notice ( |
Switch to purely namespaced enums (not yet builds on nightly)
...purely namespaced enums'