BOLT 2: `option_shutdown_anysegwit` (Feature 26/27) #672

rustyrussell · 2019-09-18T00:39:27Z

In bitcoin 0.19.0, standardness rules are going to be relaxed to allow
future witness versions. Once this is widely deployed, it will be safe
to accept them, smoothing use of future segwit versions.

See: bitcoin/bitcoin#15846

Signed-off-by: Rusty Russell rusty@rustcorp.com.au

Roasbeef

LGTM 🎷

cfromknecht

ACK, we may need to revisit depending on whether no input uses external tagging or not

cdecker · 2019-10-18T15:35:38Z

ACK e8f8a79

t-bast

ACK

Roasbeef · 2019-11-22T03:04:09Z

Can land once rebased!

rustyrussell · 2020-08-17T20:59:16Z

Assigned features 22/23.

rustyrussell · 2020-08-20T05:26:40Z

Rebased on top of master, assigned feature bits as per http://www.erisian.com.au/meetbot/lightning-dev/2020/lightning-dev.2020-08-17-20.08.html

halseth · 2020-12-22T09:47:07Z

As discussed on IRC, needs feature bit bump to not conflict with #824

cdecker · 2020-12-22T10:50:23Z

Clean rebase on top of master

cdecker · 2020-12-22T10:54:14Z

Featurebits bumped from 22/23 to 24/25 as per specification meeting 2020/12/20

t-bast

ACK 4acbb39

If two implementations can successfully test interop, we can merge this.

ariard · 2021-01-28T20:18:58Z

02-peer-protocol.md

-    4. `OP_0` `32` 32-bytes (version 0 pay to witness script hash)
+    4. `OP_0` `32` 32-bytes (version 0 pay to witness script hash), OR
+    5. if (and only if) `opt_shutdown_anysegwit` is negotiated:
+      * `OP_1` through `OP_16` inclusive, followed by a single push of 2 to 40 bytes


Beware that your is_witness_program() is bip 141 compliant, otherwise if the witness program size is unbounded the non-funder counterparty might inflate its scriptpubkey to burn in fees the funder balance.

TheBlueMatt

I'm not sure if it makes sense to clarify, but to check with others, the way I read this, if I disconnect from a peer, then reconnect with new features bits set, you can opt into onlysegwit on an old channel as long as you didn't set an upfront shutdown script. I think thats correct and a good idea.

t-bast · 2021-02-11T19:20:40Z

you can opt into onlysegwit on an old channel as long as you didn't set an upfront shutdown script. I think thats correct and a good idea.

I agree, this looks desirable and compatible with the PR.

Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).

t-bast

I implemented this in eclair and tested against c-lightning v0.10.0 (compiled with --enable-experimental-features) and didn't find any issue.

Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).

rustyrussell · 2021-05-24T21:16:23Z

Applying as per action at meeting 2021-05-24.

lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.

lightning/bolts#672 We check the received shutdown script against higher segwit versions and accept closing to that script if option_shutdown_anysegwit has been negotiated.

Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672). This is particularly useful to allow wallet users to close channels to a Taproot address.

rustyrussell added the Meeting Discussion Raise at next meeting label Sep 18, 2019

Roasbeef approved these changes Oct 18, 2019

View reviewed changes

cfromknecht approved these changes Oct 18, 2019

View reviewed changes

t-bast reviewed Oct 21, 2019

View reviewed changes

rustyrussell force-pushed the opt_shutdown_moreversions branch from e8f8a79 to 2df5c06 Compare August 20, 2020 05:25

rustyrussell added the Awaiting Interop Approved, pending 2 or more impl interoperating label Aug 20, 2020

cdecker mentioned this pull request Dec 21, 2020

Lightning Specification Meeting 2020/12/21 #827

Closed

18 tasks

cdecker force-pushed the opt_shutdown_moreversions branch from 2df5c06 to 75c02f9 Compare December 22, 2020 10:49

cdecker force-pushed the opt_shutdown_moreversions branch from 765e26d to 4acbb39 Compare December 22, 2020 10:53

t-bast reviewed Dec 22, 2020

View reviewed changes

This was referenced Jan 5, 2021

Lightning Specification Meeting 2021/01/04 #830

Closed

Lightning Specification Meeting 2021/01/18 #831

Closed

ariard mentioned this pull request Jan 18, 2021

Implement BOLT2: opt_shutdown_anysegwit lightningdevkit/rust-lightning#780

Closed

t-bast mentioned this pull request Jan 27, 2021

Lightning Specification Meeting 2021/02/01 #838

Closed

21 tasks

ariard reviewed Jan 28, 2021

View reviewed changes

t-bast mentioned this pull request Feb 9, 2021

Lightning Specification Meeting 2021/02/15 #840

Closed

23 tasks

benthecarman mentioned this pull request Feb 11, 2021

Restrictions on Script Public Keys with standardness rules discreetlogcontracts/dlcspecs#137

Merged

TheBlueMatt reviewed Feb 11, 2021

View reviewed changes

TheBlueMatt mentioned this pull request Feb 11, 2021

Add support for opt_shutdown_anysegwit feature #780 lightningdevkit/rust-lightning#794

Merged

4 tasks

TheBlueMatt mentioned this pull request Feb 11, 2021

Correct hint for P2WPKH #841

Merged

rustyrussell force-pushed the opt_shutdown_moreversions branch from 4acbb39 to e127a2a Compare February 18, 2021 05:31

rustyrussell force-pushed the opt_shutdown_moreversions branch from 4f72856 to 4e32927 Compare February 18, 2021 06:08

rustyrussell mentioned this pull request Feb 19, 2021

EXPERIMENTAL support for option_shutdown_anysegwit ElementsProject/lightning#4391

Merged

rustyrussell changed the title ~~BOLT 2: opt_shutdown_anysegwit~~ BOLT 2: option_shutdown_anysegwit Feb 19, 2021

jonatack mentioned this pull request Mar 2, 2021

Newsletters: add 138 (2021-03-03) bitcoinops/bitcoinops.github.io#523

Merged

6 tasks

niftynei changed the title ~~BOLT 2: option_shutdown_anysegwit~~ BOLT 2: option_shutdown_anysegwit (Feature 26/27) Mar 12, 2021

niftynei mentioned this pull request Mar 12, 2021

Public key-based routing (Feature **NEEDS NUMBER***) #814

Open

t-bast added a commit to ACINQ/eclair that referenced this pull request May 14, 2021

Add support for option_shutdown_anysegwit

ff813a5

Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).

t-bast mentioned this pull request May 14, 2021

Add support for option_shutdown_anysegwit ACINQ/eclair#1801

Merged

t-bast added a commit to ACINQ/eclair that referenced this pull request May 14, 2021

Add support for option_shutdown_anysegwit

a46c1aa

Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).

t-bast approved these changes May 14, 2021

View reviewed changes

t-bast added a commit to ACINQ/eclair that referenced this pull request May 17, 2021

Add support for option_shutdown_anysegwit (#1801)

5a92f84

Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).

t-bast mentioned this pull request May 19, 2021

Lightning Specification Meeting 2021/05/24 #874

Closed

10 tasks

rustyrussell merged commit 3508e4e into lightning:master May 24, 2021

bitromortac mentioned this pull request Oct 22, 2021

Implement recent spec changes regarding collab channel close outputs spesmilo/electrum#7542

Merged

3 tasks

t-bast mentioned this pull request Dec 9, 2021

Add support for option_shutdown_anysegwit ACINQ/lightning-kmp#312

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BOLT 2: `option_shutdown_anysegwit` (Feature 26/27) #672

BOLT 2: `option_shutdown_anysegwit` (Feature 26/27) #672

rustyrussell commented Sep 18, 2019

Roasbeef left a comment

cfromknecht left a comment

cdecker commented Oct 18, 2019

t-bast left a comment

Roasbeef commented Nov 22, 2019

rustyrussell commented Aug 17, 2020

rustyrussell commented Aug 20, 2020

halseth commented Dec 22, 2020

cdecker commented Dec 22, 2020

cdecker commented Dec 22, 2020

t-bast left a comment

ariard Jan 28, 2021

TheBlueMatt left a comment

t-bast commented Feb 11, 2021

t-bast left a comment

rustyrussell commented May 24, 2021

BOLT 2: option_shutdown_anysegwit (Feature 26/27) #672

BOLT 2: option_shutdown_anysegwit (Feature 26/27) #672

Conversation

rustyrussell commented Sep 18, 2019

Roasbeef left a comment

Choose a reason for hiding this comment

cfromknecht left a comment

Choose a reason for hiding this comment

cdecker commented Oct 18, 2019

t-bast left a comment

Choose a reason for hiding this comment

Roasbeef commented Nov 22, 2019

rustyrussell commented Aug 17, 2020

rustyrussell commented Aug 20, 2020

halseth commented Dec 22, 2020

cdecker commented Dec 22, 2020

cdecker commented Dec 22, 2020

t-bast left a comment

Choose a reason for hiding this comment

ariard Jan 28, 2021

Choose a reason for hiding this comment

TheBlueMatt left a comment

Choose a reason for hiding this comment

t-bast commented Feb 11, 2021

t-bast left a comment

Choose a reason for hiding this comment

rustyrussell commented May 24, 2021

BOLT 2: `option_shutdown_anysegwit` (Feature 26/27) #672

BOLT 2: `option_shutdown_anysegwit` (Feature 26/27) #672