Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly allow funding_locked early, and support alias scids (feat 46/47/50/51) #910

Merged
merged 6 commits into from
May 30, 2022
Merged

Explicitly allow funding_locked early, and support alias scids (feat 46/47/50/51) #910

merged 6 commits into from
May 30, 2022

Commits on May 30, 2022

  1. Explicitly allow funding_locked early, and support alias scids. 

    This lets you add your brand new channel to routehints, and also
means you can use a routehinted channel even if you (later?) have a
real channel.

This supports both trusted and untrusted zero-conf channels: in the
trusted case you can use it immediately like any other channel,
and for the untrusted case you simply use any push_msat they gave you
for outgoing payments, but fail incoming.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @TheBlueMatt
    rustyrussell authored and TheBlueMatt committed May 30, 2022
    Configuration menu
    Copy the full SHA
    d41cc1e View commit details
    Browse the repository at this point in the history

  2. BOLT 2: Restore minimum_depth requirement, but explicitly allow 0. 

    And weaken it: the opener doesn't need to respect it.

Note also that the `funding_locked`-can-change-alias refers to the same peer.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @TheBlueMatt
    rustyrussell authored and TheBlueMatt committed May 30, 2022
    Configuration menu
    Copy the full SHA
    faa6c41 View commit details
    Browse the repository at this point in the history

  3. BOLT 2: add channel_type for option_scid_alias 

    Allows upgrade in future.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @TheBlueMatt
    rustyrussell authored and TheBlueMatt committed May 30, 2022
    Configuration menu
    Copy the full SHA
    7aa76b6 View commit details
    Browse the repository at this point in the history

  4. channel_update: make sure we use alias scids correctly. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @TheBlueMatt
    rustyrussell authored and TheBlueMatt committed May 30, 2022
    Configuration menu
    Copy the full SHA
    f8e5c92 View commit details
    Browse the repository at this point in the history

  5. Make zeroconf a channel type, and acceptance indicates trust. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @TheBlueMatt
    rustyrussell authored and TheBlueMatt committed May 30, 2022
    Configuration menu
    Copy the full SHA
    7a812cf View commit details
    Browse the repository at this point in the history

  6. Rename funding_locked to channel_ready. 

    And `next_per_commitment_point` to explictly `second_per_commitment_point`;
this is particularly important since `channel_ready` can be retransmitted
after the channel has been in use, for example.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @TheBlueMatt
    rustyrussell authored and TheBlueMatt committed May 30, 2022
    Configuration menu
    Copy the full SHA
    34e9cd9 View commit details
    Browse the repository at this point in the history