Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really: BOLT 1: introduce warning messages, reduce requirements to send (hard) errors #950

Merged
merged 5 commits into from
Jan 3, 2022

Commits on Dec 9, 2021

  1. BOLT 1: Add warning message, remove "close all" error.

    Under this spec, an error with an all-zero channel id is ignored.
    Warnings, being odd, will be ignored by older nodes too.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    rustyrussell committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    474b68c View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Make it explicit when to send warnings, errors, fail channel and clos…

    …e connection.
    
    And make most places warn or error.  Places where we're operating
    on a channel tend to be "warn and close connection" since we want to
    forget the mistake they just sent, and closing the connection does that.
    
    We now use the same words everywhere:
    1. "fail channel" means to go onchain (if necessary).
    2. "send `error`" means to send an error message.
    3. "send `warning`" means to send a warning message.
    4. "close connection" means close the connection.
    
    These are all spelled out explicitly, rather than having "fail channel"
    imply sending an error packet, for example.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    rustyrussell committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    eb6f308 View commit details
    Browse the repository at this point in the history
  2. Update 03-transactions.md

    Co-authored-by: Bastien Teinturier <31281497+t-bast@users.noreply.github.com>
    rustyrussell and t-bast committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    4fc9f51 View commit details
    Browse the repository at this point in the history
  3. BOLT 2: Error instead of warning on shutdown on unopened channel.

    Abandoning channel is kinda what they want here.
    
    Reported-by: Matt Corallo
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    rustyrussell committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c36c14d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. BOLT 1: Restore all-zero error semantics

    There were valid uses for "I don't want to talk to you anymore" apparently!
    
    Also fixed some tabs -> spaces.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    rustyrussell committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8032f70 View commit details
    Browse the repository at this point in the history