Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebalance: average forward fee report is optional #488

Merged
merged 1 commit into from
Feb 6, 2024
Merged

rebalance: average forward fee report is optional #488

merged 1 commit into from
Feb 6, 2024

Conversation

gallizoltan
Copy link
Collaborator

  • listforwards call takes half a minute on my machine and consumes lots of memory, as I have hundreds of thousands of forwards right now
  • it's an option to turn this part of the report off, although by default it's turned on for backward compatibility (others may use this already)

rebalance: average forward fee report is optional
ec80377 
- listforwards call takes half a minute on my machine and consumes lots of memory, as I have hundreds of thousands of forwards right now
- it's an option to turn this part of the report off, although by default it's turned on for backward compatibility (others may use this already)
m-schmoock
m-schmoock approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@m-schmoock m-schmoock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jup, nothing wrong with that

@m-schmoock m-schmoock merged commit 78e2d06 into lightningd:master Feb 6, 2024
2 of 10 checks passed
@chrisguida
Copy link
Collaborator

Hey @m-schmoock can you hold off on merging more stuff for now until #484 is merged? We'd like to be able to verify that new PRs are passing CI.

@m-schmoock
Copy link
Member

Hey @m-schmoock can you hold off on merging more stuff for now until #484 is merged? We'd like to be able to verify that new PRs are passing CI.

Absolutely, sorry I was not aware that somebody was actually making this job. Thanks

@chrisguida
Copy link
Collaborator

@m-schmoock no worries!

If you have a moment, I'd love a review on the #484 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-schmoock m-schmoock m-schmoock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gallizoltan @chrisguida @m-schmoock