Upgrade to version 0.0.124 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
force-pushed
the
version-0.0.124
branch
from
885dc5c
to
e360173
Compare
tnull
reviewed
Sep 6, 2024
| @@ -290,10 +290,13 @@ public class ChannelManagerConstructor: NativeTypeWrapper { | |||
| self.customPersister = CustomChannelManagerPersister(handler: persister) | |||
| self.customEventHandler = CustomEventHandler(handler: persister) | |||
|
|
|||
| let ignoringMessageHandler = IgnoringMessageHandler() | |||
|
|
|||
| let onionMessenger = OnionMessenger.initWith(entropySource: self.constructionParameters.entropySource, nodeSigner: self.constructionParameters.nodeSigner, logger: self.constructionParameters.logger, nodeIdLookup: NodeIdLookUp(), messageRouter: MessageRouter(), offersHandler: ignoringMessageHandler.asOffersMessageHandler(), asyncPaymentsHandler: ignoringMessageHandler.asAsyncPaymentsMessageHandler(), customHandler: ignoringMessageHandler.asCustomOnionMessageHandler()) | |||
There was a problem hiding this comment.
Rather than IgnoringMessageHandler, we probably want to set ChannelManager as the OffersMessageHandler to enable BOLT12 support, no?
Btw, can we add some test coverage to check BOLT12 support is functional?
There was a problem hiding this comment.
Absolutely, I'll open an issue.
There was a problem hiding this comment.
Absolutely, I'll open an issue.
Sure, but we'll probably still want to add BOLT12 support before release I assume?
arik-so
force-pushed
the
version-0.0.124
branch
from
e360173
to
9bb5c40
Compare
tnull
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.