Use fee_satoshis when replying to quick close (as non-opener), not max_fee_satoshis
#3014
Labels
Take a Friday Leave a Friday
Stomp the Bugs, Without Much Commitment
Comments
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 23, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Apr 23, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 7, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 9, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 21, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 22, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 22, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
May 22, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#7242
endothermicdev
pushed a commit
to ElementsProject/lightning
that referenced
this issue
May 22, 2024
LDK will pick the *upper* limit (see: lightningdevkit/rust-lightning#3014)! It should not do this, but since you can set a manual range for mutual close, it's probably better to disable this option for close, as it's even more dangerous than documented. Changelog-Changed: config/JSON: --ignore-fee-limits / setchannel ignorefeelimits no longer applies to mutual close. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: #7242
TheBlueMatt
added
the
Take a Friday Leave a Friday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fee_satoshisis the amount they suggest, so you should only respond with a different amount if it's disagreeable.max_fee_satoshisis the worst case for them, so choosing it is fairly anti-social.The spec does not actually spell this out, unfortunately, but when combined with CLN's "YOLO ignore-fee-rates" option (which sets the feerate to 0xFFFFFFF), the result is stupidly expensive:
ElementsProject/lightning#7242
(And yes, v3 close fixes this, but this is deployed now...)
The text was updated successfully, but these errors were encountered: