-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option_channel_type was negotiated but channel_type is missing #6067
Comments
The above error is an eclair error |
Yes |
Seems they've changed behavior (in master?) since their last release.
Thing is, we don't necessarily know if the other side actually supports the feature when a user goes to open a channel type. So we opt to not use explicit funding if the user doesn't select a type manually. As the spec is written right now, it's technically ok for them to always require it (the "MAY" wording), but there're still some other ambiguous cases, like: we don't set it, but they do (in accept_channel) now we both go to implicit. So it's up to an implementation today if they always want it or not. edit: ok so we were compatible with the pre feature bit version (their original deployment), but seems not their current master branch (post feature bit)? |
Ok, cleared things up here with some of the other BOLT-ers, we can both ensure that users don't get downgraded, but also maintain compat across all levels. We'll soon have some CI up to run cdecker's old cross-impl tests to make sure this gets caught during the rc process (ideally we only target the last major release, since the master branch can at times be a moving target). |
In this commit, we switch to always sending a channel type when we're in explicit mode. This is compatible with prior versions of lnd as they won't send a channel type, and we'll just arrive at the same type via the existing implicit funding. Fixes lightningnetwork#6067
In this commit, we switch to always sending a channel type when we're in explicit mode. This is compatible with prior versions of lnd as they won't send a channel type, and we'll just arrive at the same type via the existing implicit funding. Fixes lightningnetwork#6067
In this commit, we switch to always sending a channel type when we're in explicit mode. This is compatible with prior versions of lnd as they won't send a channel type, and we'll just arrive at the same type via the existing implicit funding. Fixes lightningnetwork#6067
In this commit, we switch to always sending a channel type when we're in explicit mode. This is compatible with prior versions of lnd as they won't send a channel type, and we'll just arrive at the same type via the existing implicit funding. Fixes lightningnetwork#6067
Background
Cannot open a channel to Eclair
Your environment
option_payment_metadata
ACINQ/eclair#2063Steps to reproduce
lncli openchannel
Expected behaviour
Channel opened.
Actual behaviour
Error:
option_channel_type was negotiated but channel_type is missing
Investigation
It seems that lnd is silently not sending the channel type tlv when
OpenChannelRequest.CommitmentType
isn't set. Thelncli
default is to not set the channel type.lnd/rpcserver.go
Line 1995 in c75c3bd
The text was updated successfully, but these errors were encountered: