build: create v0.17.1 rc3 release branch #8162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the following could happen: * InboundPeerConnected is called while we already have an inbound connection with the peer. This calls removePeer which calls Disconnect. * If the peer is starting up in Start, it may be sending messages synchronously via SendMessage(true, ...). This eventually calls the writeMessage function which will exit if disconnect is set to 1. * Since Disconnect was called, disconnect will be 1 and writeMessage will exit, causing writeHandler to exit. * If there is more than 1 message being sent, later messages will queue in queueHandler but be unable to get into sendQueue as the writeHandler goroutine has exited. * The synchronous sends will be waiting on the errChan indefinitely and startReady will never get closed meaning Disconnect will never proceed. The end result is that the server's mutex will be held until shutdown. Avoid this by using writeMessage to bypass the writeHandler goroutine.
Roasbeef
changed the title
Roasbeef
merged commit eea15f0
into
lightningnetwork:v0-17-1-branch-rc3
20 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a bug fix for a potential deadlock in the peer handling logic.