Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beat [0/4]: improve itest miner #8892

Merged
merged 15 commits into from
Jul 23, 2024
Merged

Beat [0/4]: improve itest miner #8892

merged 15 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. lntest: create new package lntest/miner for itest miner 

    This commit moves the `HarnessMiner` into a new package to avoid
confusion about incoming changes.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a881477 View commit details
    Browse the repository at this point in the history

  2. lntest: move mining methods into one file

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    91b20e6 View commit details
    Browse the repository at this point in the history

  3. lntest+itest: strictly define the behavior of MineBlocks 

    This commit adds more assertion to `MineBlocks` so the caller won't
misuse it.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e553895 View commit details
    Browse the repository at this point in the history

  4. lntest+itest: add method AssertNumTxsInMempool and AssertTxInBlock 

    in harness

Prepare to make `HarnessTest.Miner` a private instance to sync height.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    976bb37 View commit details
    Browse the repository at this point in the history

  5. lntest+itest: continue removing direct call to Miner

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6bd8bae View commit details
    Browse the repository at this point in the history

  6. lntest+itest: finalize moving miner methods

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    be4dba5 View commit details
    Browse the repository at this point in the history

  7. lntest+itest: make Miner a private instance

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    14e7b13 View commit details
    Browse the repository at this point in the history

  8. lntest+itest: add new method CurrentHeight

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f1f3410 View commit details
    Browse the repository at this point in the history

  9. itest: fix misuse of MineBlocks and replace it with 

    `MineBlocksAndAssertNumTxes`
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8240a87 View commit details
    Browse the repository at this point in the history

  10. lntest: remove redundant nodes shutdown 

    The nodes are already shut down in the `Cleanup` in `ht.Subtest` so
there's no need to shutdown them again.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    623f816 View commit details
    Browse the repository at this point in the history

  11. itest: remove unused param in chanRestoreViaRPC

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5027946 View commit details
    Browse the repository at this point in the history

  12. multi: make sure missionControlStore catches done signal 

    This commit makes sure `missionControlStore` catches the shutdown signal
when draining the ticker. A few debug logs are added to aid the process.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2608c08 View commit details
    Browse the repository at this point in the history

  13. lntest+itest: fix flakes found using neutrino backend 

    This commit makes sure the sweep requests are received before mining
blocks to trigger the actual sweeping.

In addition, `testFundingExpiryBlocksOnPending` is updated to deal with
the old `channel link not found` issue.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4dcce9d View commit details
    Browse the repository at this point in the history

  14. docs: update release notes

    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2d21aa3 View commit details
    Browse the repository at this point in the history

  15. itest: fix testUnconfirmedChannelFunding for neutrino 

    This test was previously working because we'd mine an extra block to
confirm the coins inside `FundCoinsUnconfirmed` when it's a neutrino
backend, as shown in
https://github.com/lightningnetwork/lnd/blob/fdd28c8d888792ea8fde3c557ba9f2594e0a6ec8/lntest/harness.go#L1431
Since neutrino has trouble seeing unconfirmed balance, we now send some
coins to the wallet, confirm those, then do a self-transfer so the node
will have unconfirmed outputs to perform the test.
    @yyforyongyu
    yyforyongyu committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9180762 View commit details
    Browse the repository at this point in the history