-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rb micro fixes #8994
Rb micro fixes #8994
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
46cd14d
to
7aafa94
Compare
lnrpc/lightning.proto
Outdated
bool is_blinded = 29; | ||
|
||
/* | ||
Config values to use when creating blinded paths for this invoice. | ||
*/ | ||
BlindedPathConfig blinded_path_config = 30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this change in field number is fine if we get this into 0.18.3 (if it doesnt make that release then i'll change is_blinded
to 30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🧇
7aafa94
to
42ea098
Compare
The BlindedPathConfig struct is nice for invoice creation but when we use the Invoice message for viewing an invoice, it would be nicer to see an "is_blinded" field.
This purely affects logging. This makes sure that the `padStat` finalPaddedSize field is initilised correctly with the given minSize.
42ea098
to
ab28cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
2 micro changes:
lnrpc.Invoice
structsBlindedPathConfig
is set to an empty non-nil value to show that the invoice has blinded paths.padHopInfo
function.