Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightstep fork of go-contrib instrumentation/host metrics #268

Merged
merged 8 commits into from
Sep 7, 2022

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Sep 2, 2022

Description: The go-contrib instrumentation/host package features several process-level metrics. These are candidates for inclusion in the runtime package and are candidates for the Golang runtime/metrics package to produce. Therefore, they are moved into a new package and this package retains only the system.* metrics.

Link to tracking Issue:
Part of #257. Part of #270.

Testing: New tests added.

Documentation: doc.go updated.

@jmacd
Copy link
Member Author

jmacd commented Sep 2, 2022

Reviewers note: This is a fork which only removes code. The process.* metrics in this package are removed because they are potentially runtime metrics or can be produced with fewer dependencies. In practice, a user may not want this package of host metrics when the OTC hostmetrics receiver is available.

@codecov-commenter
Copy link

Codecov Report

Base: 94.14% // Head: 93.57% // Decreases project coverage by -0.56% ⚠️

Coverage data is based on head (825101e) compared to base (0883c13).
Patch coverage: 75.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   94.14%   93.57%   -0.57%     
==========================================
  Files          67       68       +1     
  Lines        3533     3644     +111     
==========================================
+ Hits         3326     3410      +84     
- Misses        158      174      +16     
- Partials       49       60      +11     
Impacted Files Coverage Δ
lightstep/instrumentation/host/host.go 75.67% <75.67%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mwear
Copy link

mwear commented Sep 6, 2022

Do we expect to maintain this fork for the long term, or is it temporary until the upstream library can be updated?

@jmacd
Copy link
Member Author

jmacd commented Sep 7, 2022

We would not maintain any of the instrumentation packages in otel-launcher-go if they are accepted upstream. The rate of upstream releases is very slow right now, so I'm avoiding. I will discuss this problem area in the Go SIG tomorrow.

@jmacd
Copy link
Member Author

jmacd commented Sep 7, 2022

@jmacd jmacd merged commit ff08f66 into main Sep 7, 2022
@jmacd jmacd deleted the jmacd/hostprocess branch September 7, 2022 15:53
@jmacd jmacd mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants