Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU runtime and timing metrics #269

Merged
merged 13 commits into from
Sep 7, 2022
Merged

CPU runtime and timing metrics #269

merged 13 commits into from
Sep 7, 2022

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Sep 2, 2022

Description:

Produces process.cpu.time metrics, formerly produced by the go-contrib instrumentation/host package. This is not host instrumentation, could become runtime instrumentation.

Part of #257. Part of #270.

Link to tracking Issue:

Testing: < Describe what testing was performed and which tests were added.>

Documentation: < Describe the documentation added.>

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Base: 93.64% // Head: 93.38% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (19f3840) compared to base (0615899).
Patch coverage: 81.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   93.64%   93.38%   -0.27%     
==========================================
  Files          68       69       +1     
  Lines        3669     3749      +80     
==========================================
+ Hits         3436     3501      +65     
- Misses        181      190       +9     
- Partials       52       58       +6     
Impacted Files Coverage Δ
lightstep/instrumentation/cputime/cputime.go 81.25% <81.25%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@paivagustavo paivagustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lightstep/instrumentation/cputime/cputime_test.go Outdated Show resolved Hide resolved
@jmacd
Copy link
Member Author

jmacd commented Sep 7, 2022

FYI @paivagustavo I created cputime_unix.go and cputime_other.go with two implementations; the original (copied from upstream host instrumentation) is a fallback based on gopsutil, the new based on syscall works for unix/darwin w/o a large dependency.

@jmacd jmacd merged commit 5b26476 into main Sep 7, 2022
@jmacd jmacd deleted the jmacd/cputime branch September 12, 2022 18:18
@jmacd jmacd mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants