Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version selection for builtin metrics libraries #274

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Sep 8, 2022

Description:
Introduce a configuration mechanism to select which builtin instrumentation is used.

Link to tracking Issue:
Fixes #270

Testing:
New test coverage.

Documentation:
New README section.

@jmacd jmacd requested a review from smithclay September 8, 2022 16:55
@codecov-commenter
Copy link

Codecov Report

Base: 92.82% // Head: 93.00% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (43f549e) compared to base (5b26476).
Patch coverage: 94.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   92.82%   93.00%   +0.17%     
==========================================
  Files          71       71              
  Lines        3863     3890      +27     
==========================================
+ Hits         3586     3618      +32     
+ Misses        207      203       -4     
+ Partials       70       69       -1     
Impacted Files Coverage Δ
pipelines/common.go 100.00% <ø> (ø)
pipelines/metrics.go 72.25% <92.59%> (+6.34%) ⬆️
launcher/config.go 89.39% <100.00%> (+1.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Show resolved Hide resolved
@jmacd jmacd merged commit 4b505bc into main Sep 8, 2022
@jmacd jmacd deleted the jmacd/builtinchoice branch September 8, 2022 20:34
@jmacd jmacd mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the builtin metrics support
3 participants