-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API hint for per-instrument temporality selection #426
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 87.87% 87.78% -0.10%
==========================================
Files 75 74 -1
Lines 4288 4305 +17
==========================================
+ Hits 3768 3779 +11
- Misses 445 449 +4
- Partials 75 77 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making this change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description: Support an API hint for controlling temporality. This is needed for Lightstep internally to support its current synchronous Gauge workaround combined with ordinary OTel UpDownCounter instruments since we need different temporality settings for these two use-cases (i.e., delta Gauges and cumulative UpDownCounters).
Link to tracking Issue: Part of https://lightstep.atlassian.net/browse/LS-45763.
Testing: An existing API-Hint test was extended to cover the new setting.
Documentation: ✅