Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API hint for per-instrument temporality selection #426

Merged
merged 5 commits into from
Apr 27, 2023

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Apr 27, 2023

Description: Support an API hint for controlling temporality. This is needed for Lightstep internally to support its current synchronous Gauge workaround combined with ordinary OTel UpDownCounter instruments since we need different temporality settings for these two use-cases (i.e., delta Gauges and cumulative UpDownCounters).

Link to tracking Issue: Part of https://lightstep.atlassian.net/browse/LS-45763.

Testing: An existing API-Hint test was extended to cover the new setting.

Documentation:

@jmacd jmacd requested a review from paivagustavo April 27, 2023 19:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 75.86% and project coverage change: -0.10 ⚠️

Comparison is base (1d4b504) 87.87% compared to head (a094354) 87.78%.

❗ Current head a094354 differs from pull request most recent head d7e34a7. Consider uploading reports for the commit d7e34a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   87.87%   87.78%   -0.10%     
==========================================
  Files          75       74       -1     
  Lines        4288     4305      +17     
==========================================
+ Hits         3768     3779      +11     
- Misses        445      449       +4     
- Partials       75       77       +2     
Impacted Files Coverage Δ
...p/sdk/metric/aggregator/aggregation/temporality.go 65.21% <71.42%> (+9.66%) ⬆️
...ghtstep/sdk/metric/internal/viewstate/viewstate.go 97.69% <80.00%> (-0.96%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@moh-osman3 moh-osman3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this change!

lightstep/sdk/metric/internal/viewstate/viewstate_test.go Outdated Show resolved Hide resolved
lightstep/sdk/metric/aggregator/aggregation/temporality.go Outdated Show resolved Hide resolved
Copy link

@paivagustavo paivagustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd merged commit 89adab8 into main Apr 27, 2023
@jmacd jmacd deleted the jmacd/config_tempo branch April 27, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants