[sdk/trace] support trace exporter that uses a batch processor and otlp exporter #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
changed the title
moh-osman3
force-pushed
the
mohosman/LS-47833/support-collector-based-exporting-for-traces
branch
from
37e51f5
to
760b229
Compare
jmacd
approved these changes
Jun 5, 2023
| "go.opentelemetry.io/otel/sdk/trace" | ||
| ) | ||
|
|
||
| func copyAttributes(dest pcommon.Map, src attribute.Set) { |
There was a problem hiding this comment.
Will you add a TODO saying to consider creating an internal package somewhere near the top where the metrics and trace SDK can share this sort of common code?
There was a problem hiding this comment.
Thanks for the review! Added the TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding support for collector based exporting (using batch processor and otlp exporter) for otel-go traces
Testing:
Successfully sent traces using a trace exporter from this change