Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-instrumentation options; event timestamp bug fix #494

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Jun 26, 2023

Description:

  1. Renames the SDK's otelcol exporter name to indicate whether traces or metrics
  2. Fixes a span event timestamp bug (use of Nanoseconds vs UnixNano,🩸)
  3. Adds boolean options for self-spans and self-metrics
  4. Disables self-spans by default, enables self-metrics by default

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.23 ⚠️

Comparison is base (a56cd59) 89.72% compared to head (5c3e341) 89.49%.

❗ Current head 5c3e341 differs from pull request most recent head 32335c5. Consider uploading reports for the commit 32335c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   89.72%   89.49%   -0.23%     
==========================================
  Files          62       62              
  Lines        3552     3570      +18     
==========================================
+ Hits         3187     3195       +8     
- Misses        277      281       +4     
- Partials       88       94       +6     
Impacted Files Coverage Δ
lightstep/sdk/metric/internal/doevery/doevery.go 76.19% <ø> (ø)
...p/sdk/metric/internal/syncstate/refcount_mapped.go 100.00% <ø> (ø)
...htstep/sdk/metric/exporters/otlp/otelcol/client.go 71.92% <53.84%> (-2.60%) ⬇️
...ghtstep/sdk/trace/exporters/otlp/otelcol/client.go 66.66% <53.84%> (-1.71%) ⬇️
lightstep/sdk/trace/exporters/otlp/otelcol/otlp.go 81.25% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmacd jmacd merged commit 60f3b94 into main Jun 26, 2023
@jmacd jmacd deleted the jmacd/trace_fixes branch June 26, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants