Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the concurent batch processor from SDK exporters #569

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Nov 21, 2023

Description: We have several high-volume span producers that will benefit from concurrency.
Meanwhile, the new processor will not harm existing low-volume users, so we use it unconditionally.

Batching parameters have been set to 1000/1500 (batch_size / max_size) and 32MiB in flight.

Link to tracking Issue:
Fixes #568

@jmacd
Copy link
Member Author

jmacd commented Nov 21, 2023

LS-54663

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (69c6e8c) 89.41% compared to head (987c178) 89.53%.

❗ Current head 987c178 differs from pull request most recent head 1f01e2e. Consider uploading reports for the commit 1f01e2e to get more accurate results

Files Patch % Lines
...htstep/sdk/metric/exporters/otlp/otelcol/client.go 87.50% 1 Missing ⚠️
...ghtstep/sdk/trace/exporters/otlp/otelcol/client.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   89.41%   89.53%   +0.11%     
==========================================
  Files          62       62              
  Lines        3600     3602       +2     
==========================================
+ Hits         3219     3225       +6     
+ Misses        287      285       -2     
+ Partials       94       92       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmacd jmacd merged commit 7a6d25e into main Nov 21, 2023
1 check passed
@jmacd jmacd deleted the jmacd/update_to_batch branch November 21, 2023 18:26
@jmacd jmacd mentioned this pull request Nov 27, 2023
jmacd added a commit that referenced this pull request Nov 27, 2023
**Description:** This includes #569.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support high-volume span producers
3 participants