exporter: allow custom meter/trace providers #739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature to allow passing in a custom trace and metric provider for the self-reporting features.
To do this, alter
NewExporter
to employ the variadic options pattern over a new options struct,ExporterOptions
.Options
is already used by the someConfig
building contraptions.This does make the package namespace a little crowded...
With*
functions can apply to either the exporter or the config, but I don't know that makes it confusing enough to split things up yet.