Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: allow custom meter/trace providers #739

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

gdvalle
Copy link
Member

@gdvalle gdvalle commented Jul 26, 2024

This adds a feature to allow passing in a custom trace and metric provider for the self-reporting features.

To do this, alter NewExporter to employ the variadic options pattern over a new options struct, ExporterOptions. Options is already used by the some Config building contraptions.

This does make the package namespace a little crowded... With* functions can apply to either the exporter or the config, but I don't know that makes it confusing enough to split things up yet.

@gdvalle gdvalle requested a review from jmacd July 26, 2024 17:49
@gdvalle gdvalle merged commit 359cc94 into main Jul 29, 2024
1 check passed
@gdvalle gdvalle deleted the gtd.custom-providers branch July 29, 2024 18:45
@jmacd jmacd mentioned this pull request Sep 6, 2024
jmacd added a commit that referenced this pull request Sep 9, 2024
- SDK-internal metrics: replace "otelcol_" prefix with "otelsdk_"
[#760](#760)
- Traces exporter: allow custom meter/trace providers
[#739](#739)
- Use correct default retry settings.
[#741](#741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants