Add admission control to traces sdk #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds in admission control for the traces sdk pipeline. This is to address high memory usage for some services using our traces SDK. This PR avoids unnecessary allocations by rejecting requests before they are converted to pdata if the approximated request size is larger than the configured limit.
The traces sdk has a concurrentbatchprocessor in its collector pipeline which might be ineffective at dropping requests in the case that requests are batched quicker than the requests themselves are entering the sdk. The concurrentbatchprocessor also does not have a waiter limit.