Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate the border line of iframe #6

Open
wants to merge 1 commit into
base: zh
Choose a base branch
from

Conversation

laiyenju
Copy link

@laiyenju laiyenju commented Mar 18, 2020

The original iframe style may display frame border.
I add an argument border: 0 to fix the problem. Make the iframe looks cleaner.

Here is the effect I tried on my Jekyll blog: https://laiyenju.github.io/datanews-0

The original iframe style may display frame border.
I add an argument `border: 0` to fix the problem. Make the iframe looks more clean.

Here is the effect I tried on my Jekyll blog: https://laiyenju.github.io/datanews-0
@nwingt
Copy link
Member

nwingt commented Mar 18, 2020

Thank you for your suggestion, actually the existing integration guide on Jekyll does not meet the standard iframe integration, which states in this guide. Do you mind to follow 2nd and 3rd steps of the guide and update for Jekyll accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants