fix: parsing scientific notation in SVG path #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphlinus
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks! I actually have a local branch called "fix_svg_exp" with the exact change and a commit comment saying "WIP, really needs a test." So thanks for getting this in.
We have a policy of "author commits" for substantive changes. This is a smaller one (but one that fixes a real bug) so it's up to you whether you'd like us to merge or whether you'd like write access.
|
No need to give me write access yet (if I end up wanting to make larger contributions we can revisit). I am happy to just get this in whichever way is faster. |
|
Thanks! I just added it to the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
The SVG parsing code failed to parse scientific notation in
BezPath. For exampleM 0 0 L 1e-123 -4E+5would fail to parse withSvgParseError::Wrongeven though it is a valid SVG path. This error was introduced by 8d10d4e which forgot to negate the conditional, causing the parser to fail when it should succeed.After this change
The change fixes the error and adds a test for it.