Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] The proj files have been updated to enable SourceLink #57

Closed
wants to merge 1 commit into from

Conversation

JTOne123
Copy link
Contributor

CSProj files have been updated to enable SourceLink in your nuget

[This pull request was created with an automated workflow]

I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.

We have to take 2 steps:

  1. Please approve this pull request and make .NET a better place for .NET developers and their debugging.
  2. Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink
https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater

If you notice any flaws, please comment and I will try to make fixes manually

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files          22       22           
  Lines        4043     4043           
  Branches     1026     1026           
=======================================
  Hits         2765     2765           
  Misses       1133     1133           
  Partials      145      145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cef1cf...1393b0e. Read the comment docs.

@goofballLogic
Copy link
Member

@asbjornu @wattsm any knowledge of this system? I've not encountered it before... If it's becoming a standardised .NET way of working then I'm supportive but I think we should steer away from proprietary tools/frameworks/systems which have any potential to introduce barriers to usage.

@asbjornu
Copy link
Member

asbjornu commented Jul 2, 2020

I think this is a nice addition, but I would love to revisit this once #58 is complete, since then we have in place a method to actually publish the sources to NuGet (automatically).

@stale
Copy link

stale bot commented Oct 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2020
@goofballLogic
Copy link
Member

pending #58

@stale stale bot removed the stale label Oct 1, 2020
@asbjornu
Copy link
Member

asbjornu commented Oct 3, 2020

#58 is now merged, so a rebase against the HEAD of master would be appreciated. Also please have a look at the GitHub Actions workflow to see if any adjustments are needed there in order for SourceLink to work as intended.

@asbjornu
Copy link
Member

asbjornu commented Oct 8, 2020

@JTOne123 ping?

@JTOne123
Copy link
Contributor Author

JTOne123 commented Oct 9, 2020

Sorry, I don't have time to fix it now. So please feel free to do it by yourself or just close the PR

@asbjornu asbjornu mentioned this pull request Oct 10, 2020
@asbjornu asbjornu closed this in #87 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants