2.161.3: cherry-pick #1699 #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the proxy transports `CONNECT` requests, the client silently ignores `content-length` and `transport-encoding` response headers, as it should. When the proxy passees these headers to the hyper server, it errors (as is dictated by the RFC). This change updates the HTTP client to remove these headers from responses so that the proxy no longer propagates these illegal headers. Fixes linkerd/linkerd2#8539 Signed-off-by: Oliver Gould <ver@buoyant.io>
|
Part of linkerd/linkerd2#8779 |
13 tasks
kleimkuhler
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the proxy transports
CONNECTrequests, the client silentlyignores
content-lengthandtransport-encodingresponse headers, asit should. When the proxy passees these headers to the hyper server, it
errors (as is dictated by the RFC).
This change updates the HTTP client to remove these headers from
responses so that the proxy no longer propagates these illegal headers.
Fixes linkerd/linkerd2#8539
Signed-off-by: Oliver Gould ver@buoyant.io