Update eslint config to extend more default rules #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grampelberg
approved these changes
May 29, 2018
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Unfortunately, using _.pick to pull attributes out of the component state isn't recognized as using those attributes by the react/no-unused-state eslint rule. More info here: jsx-eslint/eslint-plugin-react#1626 Rather than disable the rule entirely, I'm removing the one instance where we were picking attributes from state. Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I'm enabling more eslint rules for our react code by extending the airbnb and promise presets. I've overridden some of the rules that don't work very well with our setup, and I've converted some of our existing warn rules to error, so that we'll start failing builds when the rules are broken.
Fixes #1004.