grouped workspace list applet: move to clutter animations and undepend tweener

[anaximeno]

Also improved the scale click animation a bit.

[JosephMcc]

I haven't tested these at all but do have one piece of feedback. Please use better commit messages. A bunch of "feat: Use clutter animations" is very unhelpful when browsing the history. Much better would be something along the lines of "gwl: Update appGroup to use clutter animations". It tells me both where you made a change and what you changed in one short title. Much more useful when browsing the commit history.

[anaximeno]

I haven't tested these at all but do have one piece of feedback. Please use better commit messages. A bunch of "feat: Use clutter animations" is very unhelpful when browsing the history. Much better would be something along the lines of "gwl: Update appGroup to use clutter animations". It tells me both where you made a change and what you changed in one short title. Much more useful when browsing the commit history.

Sure, thanks for that suggestion, I was following something called conventional commits, but the way you suggest seems more adequate for this project. I'll try to follow that pattern instead on my next commits here.

[mtwebster]

I don't think this is working the way you think it is -

With easing,

• There is no time parameter, use duration instead, which expects ms, seconds.
• There is no transition parameter, use mode instead, which expects Clutter.AnimationMode.EASE_OUT_QUAD, for example.
• There is no onCompleteScope (this was completely breaking the app icon launch animation, and throwing an error into the log.

edit: Where there were missing parameters, it was just using the default values for them (probably 0 duration).

Have a look at Cinnamon's source, particularly js/ui/windowManager.js, where there are lots of examples of this.

and please test more thoroughly!

ref:
c5f76ff
#12071
#12072
#12073
etc..

[anaximeno]

I believe I saw someone using it like this on some applet so I thought it would work, I also didn't notice any issues while running and trying them locally, so thanks to that I didn't consider what you suggested before.

I will verify how this is being properly implemented inside Cinnamon (and also read some documentation) and then re-create these pull requests later. Thanks!