cs_themes: Enable stack switcher when navigating out the theme module #12300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaximeno
force-pushed
the
re-enable-stack-switcher-when-out-theme-modules
branch
from
e75c3af
to
e4d8ca2
Compare
anaximeno
force-pushed
the
re-enable-stack-switcher-when-out-theme-modules
branch
from
e4d8ca2
to
44ae4f1
Compare
anaximeno
referenced
this pull request
Aug 9, 2024
This is leftover from when we didn't hide the switcher in simple mode, but merely made it insensitive to clicks. We hide it now, there's no need for more. Fixes #12347
|
If this would have to be merged, the commit da63f90 can/should probably be reverted, because if the stack switcher at the top is not made insensitive, you still will be able to click on the invisible stack switcher in the module. |
|
Thanks, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix linuxmint/mint22-beta#42
@mtwebster @clefebvre if you could give it a look at this, it would be nice if this was patched before the stable release.