Replace tokio Mutexes with sync Mutexes #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
This MR replaces the tokio Mutexes/RwLocks with the sync Mutex/RwLock which is preferred as long as the sync Mutex is not held across
await
calls.Since the server state is now wrapped in a sync Mutex, there's no need to call
block_on
inside theDrop
implementations any more.It also replaces the tokio oneshot channel that shares the server port with a sync mpsc channel. This was the cause for the server pool blocking on
futures::future::join_all
.