Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7430] add project holi icon and styling for login button #2491

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Jul 11, 2023

…//button: add colour and hover styling

To test styling:

in provider_list.html copy div from line 21-27 and paste outside the for loop and replace {{ provider.id }}with project-holiand delete content of href

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 11.88% 84/707
🔴 Branches 13.61% 49/360
🔴 Functions 9.73% 25/257
🔴 Lines 23.15% 528/2281

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 50b5934

@philli-m philli-m force-pushed the pm-2023-07-project-holi-btn branch from 96fe53a to 72e7663 Compare July 11, 2023 12:42
@philli-m philli-m force-pushed the pm-2023-07-project-holi-btn branch from 72e7663 to 50b5934 Compare July 11, 2023 13:30
@philli-m philli-m changed the title assets/fonts: add logo as icon //icons: set icon classname and style … [7430] add project holi icon and styling for login button Jul 13, 2023
@philli-m philli-m requested a review from goapunk July 17, 2023 06:38
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@goapunk goapunk merged commit 684ce51 into main Jul 17, 2023
2 checks passed
@goapunk goapunk deleted the pm-2023-07-project-holi-btn branch July 17, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants