Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile/lint-python-file: allows isort to make changes #2495

Merged
merged 1 commit into from
Jul 18, 2023
Merged

makefile/lint-python-file: allows isort to make changes #2495

merged 1 commit into from
Jul 18, 2023

Conversation

hklarner
Copy link
Contributor

No description provided.

@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 11.88% 84/707
🔴 Branches 13.61% 49/360
🔴 Functions 9.73% 25/257
🔴 Lines 23.15% 528/2281

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ea3796c

goapunk
goapunk approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@goapunk goapunk merged commit 47219c9 into main Jul 18, 2023
2 checks passed
@goapunk goapunk deleted the hk-2023-07-allow-isort-to-sort-imports branch July 18, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

@philli-m philli-m Awaiting requested review from philli-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hklarner @goapunk