Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8304] Add geolocation tests #2764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[8304] Add geolocation tests #2764

wants to merge 1 commit into from

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Sep 17, 2024 •
edited
Loading

Fixes #2767

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@m4ra m4ra changed the title projects: add geoloation tests [8304]dd geoloation tests Sep 17, 2024
@m4ra m4ra changed the title [8304]dd geoloation tests [8304] Add geoloation tests Sep 17, 2024
@m4ra m4ra requested a review from goapunk September 17, 2024 13:46
@m4ra m4ra changed the title [8304] Add geoloation tests [8304] Add geolocation tests Sep 17, 2024
@m4ra m4ra force-pushed the mk-2024-09-add-geolocation-test branch from 5433b4b to 3d5e0ce Compare September 17, 2024 14:16
goapunk
goapunk requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a small note on some commented code / print.

tests/projects/test_project_geolocation.py Outdated

# Check if the point is correctly stored
assert fetched_project.point == geojson_point
print(fetched_project.point)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this ? :)

tests/projects/test_project_geolocation.py Outdated
):
project = project_factory(is_app_accessible=True, point=geojson_point)
module = module_factory(project=project)
# module_factory(project=project, is_draft=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this ? :)

@m4ra m4ra force-pushed the mk-2024-09-add-geolocation-test branch from 3d5e0ce to 54afaf7 Compare September 19, 2024 13:43
@m4ra m4ra requested a review from goapunk September 19, 2024 13:44
@m4ra
Copy link
Contributor Author

m4ra commented Sep 19, 2024

@goapunk added also the small fix for the app projects filter

goapunk
goapunk reviewed Sep 19, 2024
View reviewed changes
apps/projects/api.py Outdated Show resolved Hide resolved
@m4ra m4ra force-pushed the mk-2024-09-add-geolocation-test branch from 54afaf7 to 2e07a15 Compare September 23, 2024 18:25
@m4ra m4ra requested a review from goapunk September 23, 2024 18:25
goapunk
goapunk reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only a question about the past projects

apps/projects/api.py Show resolved Hide resolved
@m4ra m4ra force-pushed the mk-2024-09-add-geolocation-test branch from 2e07a15 to e344081 Compare September 26, 2024 09:39
@m4ra m4ra requested a review from goapunk September 26, 2024 09:40
goapunk
goapunk approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@goapunk goapunk self-requested a review September 26, 2024 12:14
goapunk
goapunk requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are now failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeaJayyy TeaJayyy TeaJayyy left review comments

@goapunk goapunk goapunk requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API showing only app projects
3 participants
@m4ra @goapunk @TeaJayyy