[#7864] comments and ratings: small changes following mB redesign

[hom3mad3]

dependencies:
liqd/a4-meinberlin#5686
liqd/adhocracy-plus#2747

Tasks

• PR name contains story or task reference
• Documentation (docs and inline)
• Tests (including n+1 and django_assert_num_queries where applicable)
• Changelog

[goapunk]

looks good so far, some small changes and a question about terminology

[goapunk]

when read out by a sr this will say "Click to vote up" but then say "x likes" which doesn't feel very coherent. Do we need a mechanism (flag/prop) to either use a vote terminology (aplus) or a like terminology (mB) ?

[hom3mad3]

i would suggest this needs to be unified across platforms, otherwise we are adding lots of custom flags and edge cases for the real small stuff when the component has not been designed with this in mind. i would also argue we need to move on with merging this story as not to increase the scope even more, so i can create an issue.

@TeaJayyy @CarolingerSeilchenspringer what do we do? its not so simple as the terminologies are indeed different. On mB we need the text Likes/Dislikes to show, whereas on aplus we dont show anything (which forces us to overengineer things for screen readers and have the hidden message Click to vote). Can we just have both platforms show text and then we can show and hide it visually with css on the respective forks? An idea on how not to add more logic.

[hom3mad3]

added issue: #1673

[m4ra]

@hom3mad3 the npm tests are failing. can you have a look? once resolved, I am happy to merge this PR, and following with the ones in aplus and mB right after.

added an issue for the unaddressed concern: #1673