Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIQ-179 | Added user notification for existing custom tokens #927

Merged

Conversation

mpwanyi256
Copy link
Contributor

📚 Linear Ticket 📚

@mpwanyi256 mpwanyi256 added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Nov 21, 2022
@mpwanyi256 mpwanyi256 self-assigned this Nov 21, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 21, 2022
@trafico-bot trafico-bot bot removed the 🚧 WIP Still work-in-progress, please don't review and don't merge label Nov 21, 2022
@@ -172,6 +178,10 @@ export default {
}
return null
},
tokenError() {
// TODO :: Need to add translations
return 'Already exists. Go to Token Assets.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpwanyi256 you can add this to the English translation file and get it from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jennievon Yes I needed to do that. I just wans't sure how. But I have just updated the english translation file.

Thanks

@beemi beemi merged commit 442f4cb into release-candidate-0.80.0 Nov 22, 2022
@beemi beemi deleted the liq-179/add-error-for-existing-custom-tokens branch November 22, 2022 11:52
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants