Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity filter fixes #937

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

mpwanyi256
Copy link
Contributor

📚 Linear Ticket 📚

This PR fixes issues;

  • Activity filters for all options
  • Rendering of filters where a user cannot see filters again after selection any filter option
  • Wrong Data returned on filtering

Wallet-core Related PR

@linear
Copy link

linear bot commented Nov 30, 2022

EXT-165 <P4> Wallet Activity filter always show "Completed" NFT send transaction for status like Pending, Failed, Needs Attention and Refunded

  1. Send the NFT
  2. NFT should be successfully sent and the transaction should be completed.
  3. Go to Activity filter
  4. Filter the activity for the status like Pending, Failed, Needs Attention and Refunded

if user dont have status that matches status like Pending, Failed, Needs Attention and Refunded the no result should be displayed.

Wallet Activity filter always show "Completed" NFT send transaction for status like Pending, Failed, Needs Attention and Refunded

<version, form factor, environment, and other system details>

RC 0.75.1

<Attachments such as debug logs, crash logs etc…>

Screenshot 2022-10-11 at 7.45.29 PM.png

Copy link
Member

@bradleySuira bradleySuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 30, 2022
@beemi beemi merged commit 378343b into release-candidate-0.81.0 Nov 30, 2022
@beemi beemi deleted the ext-165/activity-filter-fixes branch November 30, 2022 17:12
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants