Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ext 238 | Ethereum nft IPFS image fix #958

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Ext 238 | Ethereum nft IPFS image fix #958

merged 2 commits into from
Dec 13, 2022

Conversation

mpwanyi256
Copy link
Contributor

📚 Linear Ticket 📚

@mpwanyi256 mpwanyi256 added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 12, 2022
@mpwanyi256 mpwanyi256 self-assigned this Dec 12, 2022
@linear
Copy link

linear bot commented Dec 12, 2022

EXT-238 Fix Ethereum NFTs IPFS image issue

Here https://github.com/liquality/chainify/blob/dev/packages/evm/lib/nft/CovalentNftProvider.ts#L61 and in some place around here: https://github.com/liquality/chainify/blob/dev/packages/evm/lib/nft/OpenSeaNftProvider.ts#L42 , we seem to be missing this replace https://github.com/liquality/chainify/blob/dev/packages/evm/lib/nft/MoralisNftProvider.ts#L56

Ethereum NFTs do not show the image because of this.

ipfs.png

bradleySuira
bradleySuira approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@bradleySuira bradleySuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Dec 13, 2022
@bradleySuira bradleySuira merged commit 0e16aeb into develop Dec 13, 2022
@bradleySuira bradleySuira deleted the ext-238/Ethereum-nft-ipfs-image-fix branch December 13, 2022 12:12
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradleySuira bradleySuira bradleySuira approved these changes

@monokh monokh Awaiting requested review from monokh

@tima-t tima-t Awaiting requested review from tima-t tima-t is a code owner

@AndonMitev AndonMitev Awaiting requested review from AndonMitev AndonMitev is a code owner

@Jennievon Jennievon Awaiting requested review from Jennievon Jennievon is a code owner

@skeremidchiev skeremidchiev Awaiting requested review from skeremidchiev skeremidchiev is a code owner

@kraikov kraikov Awaiting requested review from kraikov kraikov is a code owner

@beemi beemi Awaiting requested review from beemi beemi is a code owner

Assignees

@mpwanyi256 mpwanyi256

Labels
✨ Merged Pull Request has been merged successfully size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpwanyi256 @bradleySuira