Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ref): add examples for dependabot bundler #656

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 5, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Skarlso Skarlso force-pushed the update-contribution-guide-with-example branch from 55d8068 to b958e2a Compare March 5, 2023 09:29
@Skarlso Skarlso added the kind/documentation Documentation only label Mar 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc3739d) 56.36% compared to head (370721d) 56.36%.

❗ Current head 370721d differs from pull request most recent head 65750db. Consider uploading reports for the commit 65750db to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files          57       57           
  Lines        2780     2780           
=======================================
  Hits         1567     1567           
+ Misses       1070     1069    -1     
- Partials      143      144    +1     
Impacted Files Coverage Δ
pkg/queue/queue.go 93.93% <0.00%> (-6.07%) ⬇️
infrastructure/containerd/event_service.go 59.64% <0.00%> (+3.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yitsushi yitsushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No -a please.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Skarlso Skarlso force-pushed the update-contribution-guide-with-example branch 2 times, most recently from 7d9a524 to 370721d Compare March 5, 2023 12:57
@Skarlso Skarlso requested a review from yitsushi March 5, 2023 12:58
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Skarlso Skarlso force-pushed the update-contribution-guide-with-example branch from 370721d to 65750db Compare March 5, 2023 13:28
@yitsushi yitsushi enabled auto-merge (squash) March 5, 2023 13:28
@yitsushi yitsushi merged commit 7f91723 into main Mar 5, 2023
@Skarlso Skarlso deleted the update-contribution-guide-with-example branch March 5, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants