test: Update network-interface config for e2es #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously `eth0` which led to a weird and misleading error from firecracker complaining about `network_interfaces` missing.. when the api actually accepts `network-interfaces` with a dash. This is a red-herring: really firecracker just wasn't happy with us setting `eth0` because it apparently uses that for something else. I also updated the images used in the test to use our official builds.
Callisto13
added
kind/bug
yitsushi
approved these changes
Mar 10, 2023
|
Yeh i will do a separate PR with a note and adding the failure to the troubleshooting guides, because it is the most irritating error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously
eth0which led to a weird and misleading error from firecracker complaining aboutnetwork_interfacesmissing.. when the api actually acceptsnetwork-interfaceswith a dash. This is a red-herring: really firecracker just wasn't happy with us settingeth0because it apparently uses that for something else.I also updated the images used in the test to use our official builds.