Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lights: supported color mode cleanup and documentation improvement #135

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

make-all
Copy link

Per comments on PR #134

  • use generic light implementation of supported_color_modes
  • add documentation for other remote types
  • reformat table and add missing parameters
  • reword device config section to avoid confusing with the HA config section above

Even though the existing configs are all for Broadlink remote codes,
users may want to know for future how to configure other remotes.

Reformatted table.

Reword section on device configs to avoid confusion with the
configuration.yaml config.
Use the base class's _attr_supported_color_modes rather than tracking
the support separately and overriding the property.
@litinoveweedle litinoveweedle merged commit 8ed2972 into litinoveweedle:lights Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants