Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probe): Converting probeStatus to enum and add mode and description #566

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ispeakc0de
Copy link
Member

@ispeakc0de ispeakc0de commented Sep 19, 2022

Signed-off-by: Shubham Chaudhary shubham.chaudhary@harness.io

What this PR does / why we need it:

Probe Statuses

{
  "probeStatuses": [
    {
      "mode": "SOT",
      "name": "probe1",
      "status": {
        "description": "Probe didn't met the passing criteria",
        "verdict": "Failed"
      },
      "type": "httpProbe"
    },
    {
      "mode": "Continuous",
      "name": "probe2",
      "status": {
        "description": "either probe is not executed or not evaluated",
        "verdict": "N/A"
      },
      "type": "httpProbe"
    }
  ]
}

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

@ispeakc0de ispeakc0de marked this pull request as ready for review September 19, 2022 06:29
neelanjan00
neelanjan00 previously approved these changes Sep 20, 2022
ksatchit
ksatchit previously approved these changes Sep 20, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
@ispeakc0de ispeakc0de merged commit 84854b7 into litmuschaos:master Sep 20, 2022
SaptarshiSarkar12 pushed a commit to SaptarshiSarkar12/litmus-go that referenced this pull request Sep 21, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
Signed-off-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
chinmaym07 pushed a commit to chinmaym07/litmus-go that referenced this pull request Sep 24, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
chinmaym07 pushed a commit to chinmaym07/litmus-go that referenced this pull request Sep 24, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
ispeakc0de added a commit to ispeakc0de/litmus-go that referenced this pull request Oct 6, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
ispeakc0de added a commit that referenced this pull request Oct 6, 2022
* fix(probe): Converting probeStatus as enum (#566)

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

* update(sdk): updating operator sdk version (#571)

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

* chore(httpProbe): Remove responseTimeout field, use the global probeTimeout field instead (#574)

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>

* Chore(cmd-probe): Use experiment envs and volume in probe pod (#572)

* Chore(cmd-probe): Use experiment envs and volume in probe pod

Signed-off-by: uditgaurav <udit@chaosnative.com>

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
Signed-off-by: uditgaurav <udit@chaosnative.com>
Co-authored-by: Udit Gaurav <35391335+uditgaurav@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants