fix(probe): Resiliency Score reaches more than 100 % with Probe failure #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
…t passed in postchaos phase with stopOnfailure set to false Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
ispeakc0de
changed the title
ispeakc0de
changed the title
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
neelanjan00
reviewed
Sep 21, 2022
neelanjan00
previously approved these changes
Sep 21, 2022
uditgaurav
previously approved these changes
Sep 21, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
ispeakc0de
dismissed stale reviews from uditgaurav and neelanjan00
via
0181919
neelanjan00
approved these changes
Sep 21, 2022
uditgaurav
approved these changes
Sep 21, 2022
SaptarshiSarkar12
pushed a commit
to SaptarshiSarkar12/litmus-go
that referenced
this pull request
Sep 21, 2022
…re (litmuschaos#568) * chore(probe): remove ambiguous attribute phase Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * chore(probe): handle edge mode when probe failed in prechaos phase but passed in postchaos phase with stopOnfailure set to false Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * chore(probe): fixed the probeSuccessPercentage > 100 issue Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * add the failstep for probe failures Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * fixing onchaos probe to run only for chaos duration Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> Signed-off-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
chinmaym07
pushed a commit
to chinmaym07/litmus-go
that referenced
this pull request
Sep 24, 2022
…re (litmuschaos#568) * chore(probe): remove ambiguous attribute phase Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * chore(probe): handle edge mode when probe failed in prechaos phase but passed in postchaos phase with stopOnfailure set to false Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * chore(probe): fixed the probeSuccessPercentage > 100 issue Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * add the failstep for probe failures Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> * fixing onchaos probe to run only for chaos duration Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Chaudhary shubham.chaudhary@harness.io
What this PR does / why we need it:
Issue fixed:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag