-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactos: GraphQL Server to Remove unused RBAC's #4265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
LGTM 🚀 |
3 tasks
Saranya-jena
requested review from
Saranya-jena and
namkyu1999
and removed request for
Saranya-jena
November 10, 2023 06:54
Saranya-jena
requested changes
Nov 10, 2023
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
RipulHandoo
force-pushed
the
deprecatedRABC
branch
from
November 10, 2023 17:33
d7d96ab
to
8046556
Compare
Hey @RipulHandoo , Can you check |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Saranya-jena
changed the title
Refactos: GraphQL Server to Remove unused RABC's
Refactos: GraphQL Server to Remove unused RBAC's
Nov 15, 2023
@namkyu1999 PTAL! |
namkyu1999
requested changes
Nov 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments, please!
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
RipulHandoo
force-pushed
the
deprecatedRABC
branch
from
November 19, 2023 02:24
f27bbf3
to
e7c0d10
Compare
namkyu1999
approved these changes
Nov 19, 2023
SarthakJain26
approved these changes
Feb 12, 2024
Saranya-jena
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removed deprecated and unused RBACs:
SyncHub
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
This PR solve issue #4120, by removing the unused RBAC's