verifying EnvironmentID before creating infrastructure #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhanush0369 <dhanush789245@gmail.com>
vanshBhatia-A4k9
approved these changes
Mar 4, 2024
|
@Saranya-jena shall I close this pr and make another pr. It seems I have merged using the wrong method. Edit: The method is correct, the wrong method was about the merge commit. |
|
Sure @Dhanush0369 please open another PR if you deem this wrong |
| @@ -86,6 +86,11 @@ func (in *infraService) RegisterInfra(c context.Context, projectID string, input | |||
| return nil, errors.New("infra already exists in this project with the same name") | |||
| } | |||
|
|
|||
| // Check if EnvironmentID is valid | |||
| if _, err := in.envOperator.GetEnvironmentDetails(c, input.EnvironmentID, projectID); err != nil { | |||
| return nil, errors.New("Invalid EnvironmentID") | |||
There was a problem hiding this comment.
@Dhanush0369 have you tested these changes?
There was a problem hiding this comment.
Yes, I have attached the graphql playground pic
SarthakJain26
approved these changes
Mar 7, 2024
Saranya-jena
approved these changes
Apr 5, 2024
| @@ -86,6 +86,11 @@ func (in *infraService) RegisterInfra(c context.Context, projectID string, input | |||
| return nil, errors.New("infra already exists in this project with the same name") | |||
| } | |||
|
|
|||
| // Check if EnvironmentID is valid | |||
| if _, err := in.envOperator.GetEnvironmentDetails(c, input.EnvironmentID, projectID); err != nil { | |||
| return nil, errors.New("Invalid EnvironmentID") | |||
There was a problem hiding this comment.
Invalid EnvironmentID - > environment does not exist.
Comment on lines
+90
to
+91
| if _, err := in.envOperator.GetEnvironmentDetails(c, input.EnvironmentID, projectID); err != nil { | ||
| return nil, errors.New("Invalid EnvironmentID") |
There was a problem hiding this comment.
Suggested change
| if _, err := in.envOperator.GetEnvironmentDetails(c, input.EnvironmentID, projectID); err != nil { | |
| return nil, errors.New("Invalid EnvironmentID") | |
| if env, err := in.envOperator.GetEnvironmentDetails(c, input.EnvironmentID, projectID); err != nil || env.EnvironmentID == "" { | |
| return nil, errors.New("Invalid EnvironmentID") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #4463
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: