Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ususual space around project selection card #4676

Conversation

JanhaviAlekar
Copy link
Contributor

fixes #4675

Proposed changes

Enhancing user experience by removing unusual space around project selection card
results :
Screenshot from 2024-05-27 20-22-57

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
Copy link
Member

@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this class, not necessary but because flex-grow: 0 is a default value.

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@JanhaviAlekar
Copy link
Contributor Author

We can remove this class, not necessary but because flex-grow: 0 is a default value.

Removed it

@namkyu1999
Copy link
Member

Hi @JanhaviAlekar, can you check build-pipelines?

@Saranya-jena
Copy link
Contributor

@JanhaviAlekar can you resolve the conflicts? We can merge it afterwards.

Signed-off-by: Janhavi Alekar <97527096+JanhaviAlekar@users.noreply.github.com>
@JanhaviAlekar
Copy link
Contributor Author

@JanhaviAlekar can you resolve the conflicts? We can merge it afterwards.

Done

@Saranya-jena Saranya-jena merged commit 86e2dd7 into litmuschaos:master Aug 2, 2024
17 checks passed
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* fix ususual space around project selection card

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Removed .grow class

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* removing grow class

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

---------

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
Signed-off-by: Janhavi Alekar <97527096+JanhaviAlekar@users.noreply.github.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* fix ususual space around project selection card

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Removed .grow class

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* removing grow class

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

---------

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
Signed-off-by: Janhavi Alekar <97527096+JanhaviAlekar@users.noreply.github.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unusual space between projects in project selection screen
5 participants