Multiple project owner backend #4774

aryan-bhokare · 2024-07-18T05:24:30Z

closes #3958 #4161

Proposed changes

Work done:

Modification of db schema.
Addition of new API GetProjectOwners.
Modifications of SendInvitation API.
Modifications of LeaveProject API.
Added new API UpdateMemberRole.
Added new API DeleteProject.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: aryan <aryan1bhokare@gmail.com>

…itmuschaos#4527) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.18.0 to 0.21.0. - [Commits](golang/crypto@v0.18.0...v0.21.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.3 to 1.5.4. - [Release notes](https://github.com/golang/protobuf/releases) - [Commits](golang/protobuf@v1.5.3...v1.5.4) --- updated-dependencies: - dependency-name: github.com/golang/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raj Das <mail.rajdas@gmail.com>

This modification unables to send invite with the role as owner. Signed-off-by: aryan <aryan1bhokare@gmail.com>

This modification checks if the User is the last owner of the project and if not User can leave the project. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Allows Owner to be able to leave the project. Signed-off-by: aryan <aryan1bhokare@gmail.com>

This API is used for updating role of the member in the project. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Owner can delete project with help of this API. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Signed-off-by: aryan <aryan1bhokare@gmail.com>

…kend Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>

Signed-off-by: aryan <aryan1bhokare@gmail.com>

User cannot change role of their own, so that it will avoid edge cases like 1. User is the last owner of the project. 2. User accidentally losing owner access to the projects. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>

chaoscenter/authentication/pkg/project/repository.go

+	var project struct {
+		Members []*entities.Member `bson:"members"`
+	}
+	err := r.Collection.FindOne(context.TODO(), filter).Decode(&project)


chaoscenter/authentication/pkg/project/repository.go

+	query := bson.D{{"_id", projectID}}
+	update := bson.D{{"$set", bson.M{"members.$[elem].role": role}}}
+
+	_, err := r.Collection.UpdateOne(context.TODO(), query, update, opts)


chaoscenter/authentication/pkg/project/repository.go

+func (r repository) DeleteProject(projectID string) error {
+	query := bson.D{{"_id", projectID}}
+
+	result, err := r.Collection.DeleteOne(context.TODO(), query)


Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Modified db schema of Owner. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Added new API GetProjectOwners. Signed-off-by: aryan <aryan1bhokare@gmail.com> * fix: return type error. Signed-off-by: aryan <aryan1bhokare@gmail.com> * chore(deps): Bump golang.org/x/crypto in /chaoscenter/authentication (litmuschaos#4527) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.18.0 to 0.21.0. - [Commits](golang/crypto@v0.18.0...v0.21.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump follow-redirects in /chaoscenter/web (litmuschaos#4529) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): Bump github.com/golang/protobuf (litmuschaos#4493) Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.5.3 to 1.5.4. - [Release notes](https://github.com/golang/protobuf/releases) - [Commits](golang/protobuf@v1.5.3...v1.5.4) --- updated-dependencies: - dependency-name: github.com/golang/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raj Das <mail.rajdas@gmail.com> * Modified SendInvitation API. This modification unables to send invite with the role as owner. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Modified LeaveProject API. This modification checks if the User is the last owner of the project and if not User can leave the project. Signed-off-by: aryan <aryan1bhokare@gmail.com> * RBAC modification `LeaveProject`. Allows Owner to be able to leave the project. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Added `UpdateMemberRole` API. This API is used for updating role of the member in the project. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Fixed some syntax errors. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Updated roles for owner. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Added new API `DeleteProject`. Owner can delete project with help of this API. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Added mocks. Signed-off-by: aryan <aryan1bhokare@gmail.com> * modified go.sum Signed-off-by: aryan <aryan1bhokare@gmail.com> * Added condition `UpdateMemberRole`. User cannot change role of their own, so that it will avoid edge cases like 1. User is the last owner of the project. 2. User accidentally losing owner access to the projects. Signed-off-by: aryan <aryan1bhokare@gmail.com> * made suggested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Changed DeleteProject endpoint to have url parameter. Signed-off-by: aryan <aryan1bhokare@gmail.com> * Minor fixes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * fixed import orders Signed-off-by: aryan <aryan1bhokare@gmail.com> * fixing RoleEditor to RoleExecuter Signed-off-by: aryan <aryan1bhokare@gmail.com> --------- Signed-off-by: aryan <aryan1bhokare@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raj Das <mail.rajdas@gmail.com> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>

aryan-bhokare and others added 21 commits March 17, 2024 12:19

Modified db schema of Owner.

78b82ab

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Added new API GetProjectOwners.

962175b

Signed-off-by: aryan <aryan1bhokare@gmail.com>

fix: return type error.

0c8528e

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Modified SendInvitation API.

1de73da

This modification unables to send invite with the role as owner. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Modified LeaveProject API.

7c79813

This modification checks if the User is the last owner of the project and if not User can leave the project. Signed-off-by: aryan <aryan1bhokare@gmail.com>

RBAC modification LeaveProject.

44ae3b9

Allows Owner to be able to leave the project. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Added UpdateMemberRole API.

77bcd91

This API is used for updating role of the member in the project. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Fixed some syntax errors.

43bd3b2

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Updated roles for owner.

2ac9f7d

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Added new API DeleteProject.

1860721

Owner can delete project with help of this API. Signed-off-by: aryan <aryan1bhokare@gmail.com>

Added mocks.

a2a27d4

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Merge branch 'multiple-owner-support' into multiple-project-owner-bac…

4e8279a

…kend Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>

modified go.sum

737c03f

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Added condition UpdateMemberRole.

c1b2ed3

User cannot change role of their own, so that it will avoid edge cases like 1. User is the last owner of the project. 2. User accidentally losing owner access to the projects. Signed-off-by: aryan <aryan1bhokare@gmail.com>

made suggested changes.

197aabd

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Changed DeleteProject endpoint to have url parameter.

4a10fe3

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Minor fixes.

33dec51

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Merge branch 'master' into multiple-project-owner-backend

0fe519a

Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>

github-advanced-security bot found potential problems Jul 18, 2024

View reviewed changes

aryan-bhokare added 2 commits July 18, 2024 11:05

fixed import orders

f7062d5

Signed-off-by: aryan <aryan1bhokare@gmail.com>

fixing RoleEditor to RoleExecuter

a381cb4

Signed-off-by: aryan <aryan1bhokare@gmail.com>

Saranya-jena approved these changes Jul 18, 2024

View reviewed changes

SarthakJain26 approved these changes Jul 18, 2024

View reviewed changes

Merge branch 'master' into multiple-project-owner-backend

6427568

Saranya-jena merged commit 164e280 into litmuschaos:master Jul 22, 2024
17 of 18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple project owner backend #4774

Multiple project owner backend #4774

aryan-bhokare commented Jul 18, 2024 •

edited

Loading

Multiple project owner backend #4774

Multiple project owner backend #4774

Conversation

aryan-bhokare commented Jul 18, 2024 • edited Loading

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

aryan-bhokare commented Jul 18, 2024 •

edited

Loading